Question about: Mesh Load(string path)

[Davaris]

I just noticed this function doesn't return null, if it fails to find a file. Is there another way to check if it succeeded or failed?

 

		public static Mesh Load(string path)
	{
		return new Mesh(Core.LoadMesh(path, Entity.NullPointer));
	}

[ZioRed]

Check the Pointer of the mesh:

 

Mesh mesh = Mesh.Load("abstract::mymesh.gmf");
if (mesh.Pointer == IntPtr.Zero)
{
  // mesh not found
}

[Davaris]

Thanks.

[Rick]

Not that it's a huge deal, but that seems kind of hacky. Would seem better if we could just check the Mesh object against null.

[ZioRed]

I dislike any *.Load method and would prefer to have a constructor instead. I also think that you will never have an invalid filepath in your game unless the player has hacked it (which you should check before the game is loaded with FileSystem.GetAbsolutePath).

[Rick]

I agree that it should load in the constructor, but would still like to check the object against null instead of the .Pointer variable.

 

A file might have been deleted, so I think checking for null after loading is something that should still happen.

[TylerH]

This may be changed over in the future to do as you guys suggest, but right now the only C# system that will handle loading and such in the constructor, as well as null checks and thread safety is my GameEntity class; unfortunately, it isn't close to being finished or fully usable.

[TylerH]

Question: Maybe some custom exceptions could be thrown ?

 

public static Mesh Load(string path)
	{
try
{
		Mesh mesh = new Mesh(Core.LoadMesh(path, Entity.NullPointer));
}
catch (mesh.Pointer == Entity.NullPointer)
{
throw new LeadwerksNullEntityException();
}
	}

[ZioRed]

but would still like to check the object against null instead of the .Pointer variable.

I forgot that you can check against Entity.Null instead of null, this is how also the NET System.Data works (with DBNull.Value):

if (entity == Entity.Null)
{
  // Wrong entity
}

[Rick]

I don't think Mesh should have a Load() method. It should be in the ctor I think.

[TylerH]

I am seeing it. I will go ahead and switch that over.

[TylerH]

I don't think Mesh should have a Load() method. It should be in the ctor I think.

 

Rick do you have MSN?

[Rick]

I do, but I'm at work at the moment and can't access it here.